search

openepcis / openepcis-models

EPCIS 2.0 Java Models
https://openepcis.io
Apache License 2.0
0 stars 2 forks source link

Add DocumentType in common constants #18

Closed tnahddisttud closed 1 year ago

tnahddisttud commented 1 year ago

Following PR adds a DocumentType constant in common constants. Request you to review and approve the PR

sboeckelmann commented 1 year ago 

  public static final String EVENT_ACCESS = "event-access";
  public static final String QUERY_ROLE = "query";
  public static final String ID = "ID";
  public static final String USERINFO = "userinfo";
  public static final String SUB = "sub";
  public static final String CAPTURED_BY = "capturedBy";
  public static final String ROLES_ALLOWED = "rolesAllowed";
  public static final String SUBSCRIPTION_INTERVAL_PATH = "app.subscription.streaming-interval";

Please check if these constants really belong here. In my opinion these are very much related to the repository and might be located elsewhere in some common artifact used by those parts of the implementation using this

@tnahddisttud can you please pick this up as an additional cleanup

I have accepted you PR to not break build pipelines