Javascript onclick event empty to open in new window resources

openequella / moodle-mod_openEQUELLA

Moodle module for integration with openEQUELLA

https://openequella.github.io/moodle-mod_openEQUELLA/

GNU General Public License v3.0

6 stars 16 forks source link

Javascript onclick event empty to open in new window resources #14

Closed alex-rowe closed 11 years ago

alex-rowe commented 11 years ago

Hi, Our Equella links are not opening in a new window even though the options are now set in the Global settings page. I think there may have been changes in how popups are used in Moodle 2.4 When you view the page source the onclick event is just an empty string (onclick="") where the URL resource has it set. Looking in the course cache it is set but looks a little different to a comparable URL resource set to use popups. Let me know if you want me to do any testing.

Thanks

dcai commented 11 years ago

Thanks @agrowe

Moodle 2.4 introduces cached_mod_info object to store cminfo. EQUELLA module master branch conform this now.