openequella / moodle-mod_openEQUELLA

Moodle module for integration with openEQUELLA
https://openequella.github.io/moodle-mod_openEQUELLA/
GNU General Public License v3.0
6 stars 16 forks source link

Removing embed object resizing to prevent error in Chrome. #53

Closed nelson-edalex closed 6 years ago

nelson-edalex commented 6 years ago

When EQUELLA activity is opened with option 'open in the same window', resizing the embedded EQUELLA resource with $PAGE->requires->js_init_call('M.util.init_maximised_embed', array('resourceobject'), true); will cause error in Chrome. If the EQUELLA resource is a Youtube video, play button is not working. If the EQUELAL resource is a file, it will be downloaded twice.

This fix comments out the js_init_call() and hard-coding resource size being 100% width and 450px min-height.

mrblippy commented 6 years ago

Looks to be working in all browsers I have tested in (chrome, firefox, ie11 and edge)