search

openequella / moodle-mod_openEQUELLA

Moodle module for integration with openEQUELLA
https://openequella.github.io/moodle-mod_openEQUELLA/
GNU General Public License v3.0
6 stars 16 forks source link

Attempt to further optimise equella_list_courses_for_user web service call #63

Closed mrblippy closed 4 years ago

mrblippy commented 5 years ago

An Edalex client's moodle takes around 30 seconds to list courses using the equella_list_courses_for_user web service call (the code lives inside externallib.php)

There was an effort performed in the past to optimise this https://github.com/apereo/moodle-mod_openEQUELLA/commit/32acf7412f12fd53f8c28cedaa4560acc12b9628#diff-f232daf9e853b92201e86b2262bc9aca Part of that fix involved caching the course results. So perhaps that's no longer working?

jonof commented 5 years ago

If the user is an admin or similarly privileged user of the Moodle site, it can take a very long time to respond with a list of modifiable courses as every course in the system is individually permission checked and returned in the service response. In my test I've seen a 4.75min delay computing the response. However, with the improvements to efficiency in get_user_capability_course() with Moodle 3.4, the same result can be achieved much faster. My test: 3.5sec.

There's a commit in my fork which has the change that I'm currently evaluating, but as I haven't had an organisational CLA for my employer sent off yet, and thus no individual CLA either, it won't be accepted for merging.

Jonathon

mrblippy commented 5 years ago

I will take a look at that commit today, thanks for the explanation @jonof