search

openequella / moodle-mod_openEQUELLA

Moodle module for integration with openEQUELLA
https://openequella.github.io/moodle-mod_openEQUELLA/
GNU General Public License v3.0
6 stars 16 forks source link

openEquella resources set to display in new window produce a coding error when middle-/right-clicked to open in new tab/window #71

Closed Novocastrian closed 3 years ago

Novocastrian commented 4 years ago

Hi there!

The openEquella Resource in one of our older Moodle LMSs (3.1) has a default configuration to open openEquella resources in a new window. When you middle-click or right-click > open in new tab/window on the openEquella resource, it produces a coding error.

openEquella resource settings: image

Expected behaviour (screenshot taken from a Moodle 3.5 instance):

  1. Set display settings of an equella resource to display in a new window.
  2. Navigate to the openEquella resource in the course, then middle-click or right-click it > open in a new tab or window.
  3. Click on the link to the Equella resource: moodle 3 5 openequella in new tab result Note: the url of this page is the /mod/equella/view.php?id=somenumber page

Actual behaviour:

  1. Set display settings of an equella resource to display in a new window.
  2. Navigate to the openEquella resource in the course, then middle-click or right-click it > open in a new tab or window.
  3. Moodle serves the mod/equella/view.php?id=somenumber page, but with this error instead:

Coding error detected, it must be fixed by a programmer: check_browser_version is removed, please update your code to use core_useragent instead.

More information about this error

Coding error Higher Ed Moodle

Troubleshooting notes Developer debugging in the problematic Moodle (3.1) did not produce anything that indicates the cause of this issue. The More information about this error link suggested purging the site cache, but this did not resolve the issue either.

I am aware this is a really old version of Moodle. However, upgrading the LMS is out-of-the-question at this point in time. Thus far, I'm unsuccessful in locating other reports of this issue online (particularly this GitHub project and Moodle's English forums. Granted that people are inclined to open links in new tabs to maintain an easy reference to other resources in the course, is there a way to resolve this aside from telling people "don't middle-click or right-click Equella links as new tabs" or changing the display option?

Novocastrian commented 4 years ago

Bump. I know I am on a non-supported Moodle version (painfully aware, in fact), but is there a workaround for this issue that isn't 'upgrade moodle'?

Novocastrian commented 4 years ago

Bump. Sure is quiet here ...

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ChristianMurphy commented 4 years ago

@Novocastrian for questions, the openEquella mailing lists are a good place to reach out https://github.com/openequella/openEQUELLA/blob/5aa5588eef073446e2c003db415248c237c64f0a/CONTRIBUTING.md#chatting

Also a friendly reminder that openEquella is an open source project, if people aren't haven't encountered this issue, you are welcome to research the issue and contribute an enhancement/fix.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.