openequella / openEQUELLA

Core openEQUELLA sources
https://openequella.github.io/
Apache License 2.0
42 stars 44 forks source link

New UI IMS Package display shows nested template, hides info about the error #2873

Closed SammyIsConfused closed 2 years ago

SammyIsConfused commented 3 years ago

Describe the bug When a full page error occurs within an IMS viewer, it shows the template including the menu bar within the viewer - which can lead to nested equella windows.

To Reproduce Steps to reproduce the behavior:

  1. Go to an IMS attachment with a missing file referred to in the imsmanifest.xml and enter the viewer.
  2. Click on the missing file from within the viewer.
  3. Note that the 404 error page that displays contains the menu bar.
  4. Note that the error page just reads 404 Not Found - no info about the request that failed.

Expected behavior The error should not contain the menu bar. Also - 404 errors should display information about the request that failed - just as it does in the old UI.

Screenshots image

In the old UI, this is the error.

image

Stacktrace If applicable, a stacktrace to help explain your problem.

Platform:

SammyIsConfused commented 3 years ago

@cathfitz Carl has informed me that a client has asked about this issue again - should definitely go into 2021.2 and not later.