search

openequella / openEQUELLA

Core openEQUELLA sources
https://openequella.github.io/
Apache License 2.0
41 stars 44 forks source link

New LTI attachments always have a blank name #679

Closed doolse closed 5 years ago

doolse commented 5 years ago

Describe the bug When you create a new "External tool provider (LTI)" attachment, clicking add gives you a blank attachment. It used to go to "attachment details editor" which would have a default description and let you edit it but now that we bypass that page because of #520, you don't get an attachment name at all.

To Reproduce Steps to reproduce the behavior:

  1. Go to a contribution wizard which has an attachment control which allows LTI attachments
  2. Create a valid LTI attachment and click Add
  3. Returns back to the wizard and gives you a blank attachment entry

Expected behavior It should give you a default name for the attachment.

Screenshots image

Stacktrace If applicable, a stacktrace to help explain your problem.

Platform:

Additional context Autotest which found this - LTIAttachmentControlTest

edalex-ian commented 5 years ago

Heya @mrblippy

Could you please test on 2019.1 and 2018.2. If all good, please close.

IS

mrblippy commented 5 years ago

Verified in 2018.2 and 2019.1