search

openergy / opyplus

A package to work with EnergyPlus in python
Mozilla Public License 2.0
38 stars 13 forks source link

Al develop #42

Closed Lefort-Antoine closed 4 years ago

Lefort-Antoine commented 4 years ago

Rebuild parametric simulations test for documentation Need to add images.

zach-b commented 4 years ago

@Lefort-Antoine

I did some minor cleaning on your example, however it is still not passing the doctest tests, could you take a look at it ? It seems some variables used are not defined

I added a sample image to your example, could you add your plots in a similar manner ?

Also, could you explain a bit more after the first sentence of the example what is the goal of this sensibility study, and why it is useful ?

geoffroy-destaintot commented 4 years ago

everything looks fine, except sensitivity study figures : I find it hard to understand what the figures represent -> it would be good to improve titles, and maybe comment (for example explain which simulation is the optimal simulation)