search

openethereum / fether

Decentralized and light Ethereum Wallet
BSD 3-Clause "New" or "Revised" License
123 stars 33 forks source link

fix: Disable Electron remote module #554

Closed amaury1093 closed 5 years ago

amaury1093 commented 5 years ago

closes #548

The issue describes filtering permissions in the remote module (point 16 in https://electronjs.org/docs/tutorial/security#16-filter-the-remote-module).

Instead, I did the more drastic point 15: remove altogether the remote module.

I would appreciate yarn start and yarn electron testing, they pass on my computer.

axelchalon commented 5 years ago

Code LGTM, yarn start works ; yarn electron hangs on my computer but I think it's unrelated to this PR.