search

openethereum / fether

Decentralized and light Ethereum Wallet
BSD 3-Clause "New" or "Revised" License
123 stars 33 forks source link

Refactor URLs we allow navigation to #556

Closed axelchalon closed 5 years ago

axelchalon commented 5 years ago

Close https://github.com/paritytech/fether/issues/547

This PR only takes care of refactoring the checks when the web contents navigates to an URL. No changes made to the resources checks (i.e. images, fetches, etc.).

It would be nice to double-check if all the external links still open.

I couldn't check if the links to blockscout still work on the packaged versions as I'm getting redirected to the accounts list after staying for a few seconds on any other page; also on master. For example, clicking on "New account" and waiting a few seconds brings me back to the accounts list. Can you repro?

Tbaut commented 5 years ago

Got the following when clicking on the Blockscout:

Unable to open new window with untrusted content url due to new-window listener: https://blockscout.com/eth/kovan/tx/0xa4d0fa711acf6adf19730790ab4a149ffa748ac324ebd0cc47cdce48c4916368/internal_transactions

Other than the feedback button I don't think we have any other link do we?

Tbaut commented 5 years ago

Can you repro?

Using yarn start and yarn electron I can't reproduce. Everything's fine for me :man_shrugging: