search

openethereum / parity-deploy

Parity deployment script.
Apache License 2.0
81 stars 52 forks source link

Adding --chain option #21

Closed ddorgan closed 7 years ago

keorn commented 7 years ago

Cant it be more generic and just pass all options to the underlying nodes?

ddorgan commented 7 years ago

Ok to use --options or something like that? It's a bit of a pain to pass everything down due to how the arguments are being parsed...

keorn commented 7 years ago

Sure

ddorgan commented 7 years ago

Well I thought the idea was you could use just use --chain chain_name for a simple default and only use --parity-options if you want something different from the default.

Or it can be removed and people will need to use --parity-options "--chain chain_name --other-options"

Any preference?

keorn commented 7 years ago

Cant you just pass all unknown options to Parity?

ddorgan commented 7 years ago

Well the one advantage of keeping the --chain out of --parity-options is that it can then be used with custom networks too to enable a certain option on all the containers (e.g. debug logging), without needing to touch the template files.