search

openethereum / parity-deploy

Parity deployment script.
Apache License 2.0
81 stars 52 forks source link

(FR) user defined parameters #55

Closed drandreaskrueger closed 6 years ago

drandreaskrueger commented 6 years ago

At the moment I am manually adding

--geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http

to the resulting docker-compose.yml after running ./parity-deploy.sh --config aura --name myaura --nodes 4

A new CLI switch could be useful, like 

NODEARGS="--geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http"
./parity-deploy.sh --config aura --name myaura --nodes 4 --args $NODEARGS
docker-compose up
drandreaskrueger commented 6 years ago

workaround for now: I have added those parameters in all 4 files here.

So, feature request not indispensable, but ... nice-to-have.

drandreaskrueger commented 6 years ago

plus, one more file has to be changed, to almost never hit the gasLimit:

parity-deploy/spec/genesis/aura

to 40 million:

    "genesis": {
        "gasLimit": "0x2625A00"
    },
ddorgan commented 6 years ago

@drandreaskrueger can you just try adding all the extra options at the end of the parity-deploy.sh command ...

e.g. 

parity-deploy.sh --config aura --nodes 4 --geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http

I should maybe make this more clear in the README.

drandreaskrueger commented 6 years ago

ah, cool. Thanks.

drandreaskrueger commented 6 years ago

and the gasLimit? See https://github.com/paritytech/parity-deploy/issues/60

ddorgan commented 6 years ago

Issue resolved. Won't be updating the gasLimit.

drandreaskrueger commented 6 years ago

Won't be updating the gasLimit.

I see. What a pity.

Then please consider this route to the same effect: https://github.com/paritytech/parity-deploy/issues/60

Thanks.

ddorgan commented 6 years ago

I see. What a pity.

Let me have a look at updating the gasLimit, I'll include with the key generation changes.

ddorgan commented 6 years ago

@drandreaskrueger you can also add --gas-floor-target xxxxx at the end of the command line arguments for this by the way.

ddorgan commented 6 years ago

https://github.com/paritytech/parity-deploy/commit/0937ea2e221e31e7efc70f1e100afa038fe37d1e

drandreaskrueger commented 6 years ago

Let me have a look at updating the gasLimit

hahaha, just seen, you simply hardcoded 40 million now.

That is not what I meant. For for my one situation here, it is actually helpful, thanks.