openethereum / parity-deploy

Parity deployment script.
Apache License 2.0
81 stars 52 forks source link

instantseal password empty & chainname ignored #58

Closed drandreaskrueger closed 6 years ago

drandreaskrueger commented 6 years ago

thorough cleaning:

docker-compose down -v
docker rm $(docker ps -a -q); docker rmi $(docker images -q)
sudo rm -rf data/ deployment/ docker-compose.yml
sudo ./clean.sh 

there is a password created:

./parity-deploy.sh --config dev --name instantseal
cat  deployment/is_authority/password 

results in

s4LKh0oCw4jH1g1n

but then something's wrong:

docker-compose up

./deploy.py 
...
Traceback (most recent call last):
  File "./deploy.py", line 136, in <module>
    deployTheContract(contract_source_file=CONTRACT_SOURCE)
  File "./deploy.py", line 105, in deployTheContract
    print ("unlock: ", unlockAccount())
  File "/home/akrueger/Documents/Code/gitlab/electronDLT/chainhammer/clienttools.py", line 94, in unlockAccount
    duration=duration)
  File "/home/akrueger/Documents/Code/envs/py3eth/lib/python3.5/site-packages/web3/personal.py", line 43, in unlockAccount
    [account, passphrase, duration],
  File "/home/akrueger/Documents/Code/envs/py3eth/lib/python3.5/site-packages/web3/manager.py", line 110, in request_blocking
    raise ValueError(response["error"])

ValueError: {'code': -32023, 'data': 'InvalidPassword', 'message': 'Unable to unlock the account.'}

found it out like this

geth attach http://localhost:8545
Welcome to the Geth JavaScript console!

instance: Parity//v1.11.10-stable-31720e6-20180830/x86_64-linux-gnu/rustc1.28.0
coinbase: 0x00a329c0648769a73afac7f9381e08fb43dbea72
at block: 0 (Thu, 01 Jan 1970 01:00:00 BST)
 modules: eth:1.0 net:1.0 parity:1.0 parity_accounts:1.0 parity_set:1.0 personal:1.0 rpc:1.0 signer:1.0 traces:1.0 web3:1.0

> personal.unlockAccount(eth.accounts[0])
Unlock account 0x00a329c0648769a73afac7f9381e08fb43dbea72
Passphrase: 
true

instead of "s4LKh0oCw4jH1g1n", the password is ""

drandreaskrueger commented 6 years ago

also

./parity-deploy.sh --config dev --name instantseal

but then the chain is instead called developmentchain:

nodeName: Parity, nodeType: Parity, consensus: ???, network: 17, chainName: developmentchain, chainId: 17

see https://gitlab.com/electronDLT/chainhammer/blob/master/parity.md#run-8-instantseal

ddorgan commented 6 years ago

@drandreaskrueger Yes with the --dev chain the account password will be blank ... this is expected.

drandreaskrueger commented 6 years ago

then better don't generate an invalid password, no?

ddorgan commented 6 years ago
davidd@ThinkPad-S3-S440:/tmp$ git clone git@github.com:paritytech/parity-deploy.git
Cloning into 'parity-deploy'...
remote: Counting objects: 704, done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 704 (delta 24), reused 38 (delta 11), pack-reused 640
Receiving objects: 100% (704/704), 10.70 MiB | 5.40 MiB/s, done.
Resolving deltas: 100% (350/350), done.
cd pdavidd@ThinkPad-S3-S440:/tmp$ cd parity-deploy/
davidd@ThinkPad-S3-S440:/tmp/parity-deploy$ ./parity-deploy.sh --config dev 
using instantseal
davidd@ThinkPad-S3-S440:/tmp/parity-deploy$ cat deployment/is_authority/password 

davidd@ThinkPad-S3-S440:/tmp/parity-deploy$