Closed drandreaskrueger closed 5 years ago
quick'n'dirty fix:
sed -i 's/user:\ parity/user:\ root/g' docker-compose.yml
@drandreaskrueger version v.11.11 is actually before we introduced the parity user to the containers and we do not backport these changes to existing versions in case it breaks something. Also parity v1.x is no longer supported.
However I know you're using this version due to the performance you see there vs later versions.
But on a point of the testing, would I be right in saying you pre-sign geth transactions because you cannot do this directly? If so then shouldn't you also pre-sign the parity transactions and use a later version of the software to get an apples to apples comparison of both platforms.
Closing this as we won't be updating the v1.11.11 image, however please feel free to open another issue for any outstanding questions on this.
Hello @ddorgan
First the misunderstanding:
would I be right in saying you pre-sign geth transactions because you cannot do this directly?
No, I don't.
Where does this misunderstanding come from?
I am either using this call or I am using this call.
But neither is pre-signing.
I dimly remember that misunderstanding had happened already, a while ago. So then I wrote this page here for you. Please read this now: FAQ ... send via ...
to get an apples to apples comparison of both platforms.
yes, both geth
and parity --geth
are treated exactly identical. Already.
What I also tried out was to start parity without the --geth switch, and unlock the account per CLI; it did not give speed-up.
But:
Also parity v1.x is no longer supported.
Then I must introduce an artificial difference between parity and geth (which would forever give a disadvantage to parity):
Mentioning that here, because v1.11.11. did NOT have that issue, back then I could fire at the node from many parallel threads at once.
So ... I suggest you keep on supporting v1.11.11 somehow (see e.g. my quick fix above, that should be easy for you to implement, depending on user-chosen version number. And without "updating the v1.11.11 image").
Then I could report numbers for
What do you think?
feel free to open another issue for any outstanding questions on this.
@ddorgan (even with this #92 closed now) are my above 2 comments of today covered sufficiently, or do I have to open yet another issue?
@drandreaskrueger no that's fine. I'll send you a follow up later today with some findings...
simple patch for
v1.11.11 instantseal https://github.com/paritytech/parity-deploy/issues/76#issuecomment-456473262
v1.11.11 aura https://github.com/paritytech/parity-deploy/issues/76#issuecomment-456479049
found a new one: