openethereum / parity-deploy

Parity deployment script.
Apache License 2.0
81 stars 52 forks source link

small improvement: compare parity versions before downloading binary #97

Closed drandreaskrueger closed 5 years ago

drandreaskrueger commented 5 years ago

reproduce like this:

PARITY_VERSION=v2.2.3
sudo rm -rf paritytech_parity-deploy
git clone https://github.com/paritytech/parity-deploy.git paritytech_parity-deploy
cd paritytech_parity-deploy
git checkout 1a6afd17ac75bdf6c9e9fefa1d3af13748dd9cfa
sudo ./clean.sh
./parity-deploy.sh -r $PARITY_VERSION --config aura --nodes 4 --geth
sed -i 's/parity:stable/parity:'$PARITY_VERSION'/g' docker-compose.yml
docker-compose up

results in:

Custom parity build set: v2.2.3
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3856  100  3856    0     0    759      0  0:00:05  0:00:05 --:--:--   996
Release selected is: v2.2.3
Parity 2.2.3 already installed

--> suggestion: Do not download if version is already wanted version. Then it would look like this:

Custom parity build set: v2.2.3
Parity 2.2.3 already installed, no download needed.
ddorgan commented 5 years ago

Now using ethkey / ethstore instead of the parity binary. And the release is just passed in as the docker image to use.

drandreaskrueger commented 5 years ago

instead of the parity binary.

oh, so no more local parity download at all?

ddorgan commented 5 years ago

Closing, version now controlled via docker image only.

drandreaskrueger commented 5 years ago

version now controlled via docker image only.

sounds good.

so parity-deploy does not need any local parity installation anymore? All is working through docker now? Well done, @ddorgan !

ddorgan commented 5 years ago

@drandreaskrueger yip that is exactly the case....thanks!