[permission] new node cannot connect if "nodePermissionContract" is specified

[zean00]

Before filing a new issue, please provide the following information.

If you think that your issue is an exploitable security vulnerability, please mail your bugreport to security@parity.io instead; your submission might be eligible for our Bug Bounty. You can find mode info on the reporting process in SECURITY.md

• OpenEthereum version: 3.0.0
• Operating system: Linux
• Installation: docker
• Fully synchronized: no
• Network: private (aura)
• Restarted: yes

I've setup private network with aura consensus for 5 nodes, 3 nodes is validator nodes and 2 node is client node, I use this setup to test network permission contract

steps to reproduce

• Using parity-deploy, setup 3 validator nodes (aura) and add 2 client nodes
• Start 3 validator nodes
• Deploy the network permission contract
• Allow 3 validator nodes to connect each other
• Stop all the nodes
• Update the chain spec and add "nodePermissionContract" param
• Restart 3 validator nodes
• Start the first client node, the client node won't sync with the other 3 nodes (as expected)
• Add the first client node as a member node through the contract
• Restart the client node, the client node still not connected to the other 3 nodes (not as expected)
• Remove "nodePermissionContract" param from chain spec only for client node
• Restart client node, the client node now connected to the other 3 nodes (as expected)
• Start the 2nd client node using same chain spec with first client node, the 2nd client node is connected to first client node (not as expected)
• Stop first client node, put back "nodePermissionContract" on chain spec and restart
• Restart 2nd client node, the 2nd client node now not connected to any nodes (as expected)
• Add the 2nd client node as member node through contract
• Restart 2nd client node, the 2nd client node now not connected to all nodes (as expected)

expected behavior

• New node should be connected to other nodes as permitted within contract with exact same chain spec ("nodePermissionContract" present)
• New node should not connected to any nodes if not allowed by contract even though there are node that not set "nodePermissionContract" params on its chain spec

actual

• I need to remove "nodePermissionContract" params first to be able to connect to other nodes, then put it back that param to prevent new node connect through that node
• New node will be able to connect to the network through a node that hasn't set "nodePermissionContract" params on its chain spec

[zean00]

I've found the workaround, by including the node permission contract binary in the chain spec ( the contract should allow any connection by default) , hence the new node think that it allowed to connect to any nodes and try to connect to reserved peers or boot nodes. At least with this way, even though the new node isn't allowed to connect to anyone (based on the current state of the contract), it still try to connecting, and when it's finally allowed, it will sync up and update the contract state and I don't need to update the chain spec or restart the node

[rakita]

Seems you found solution