openethereum / parity-ethereum

The fast, light, and robust client for Ethereum-like networks.
Other
6.83k stars 1.68k forks source link

Prometheus metrics #11823

Open adria0 opened 4 years ago

adria0 commented 4 years ago

Implements #11725

vorot93 commented 4 years ago

Looks good overall.

Consider making an optional feature flag for this. Also needs a clean rebase onto master.

vorot93 commented 4 years ago

@sorpaas Not everyone needs prometheus metrics. Therefore it would be a good idea to make this a cargo feature which we could enable by default.

sorpaas commented 4 years ago

@vorot93 I honestly think it's not easy to do that. A lot of the prometheus changes require additional parameters to be set. And if we use flag for that I believe it might be really complicated.

Always building prometheus might result in slightly larger binary size, but other than that, as long as the service can be disabled runtime, it wouldn't bring any noticeable performance penalty. The prometheus service is also enabled in Substrate by default.