Closed rakita closed 4 years ago
Tested for four days, everything function as expected.
Not sure why, but test unrelated to this pull request fails on macos: command is cargo test -p ethstore-cli --test cli
i tried it on my windows machine and linux server and both tests pass. I dont have mac to check this
Running `/Users/runner/work/openethereum/openethereum/target/release/deps/cli-608eb763b339d18b`
running 1 test
test cli_cmd ... FAILED
failures:
---- cli_cmd stdout ----
thread 'cli_cmd' panicked at 'assertion failed: output.status.success()', accounts/ethstore/cli/tests/cli.rs:29:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
cli_cmd
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '-p ethstore-cli --test cli'
Blocked. The test fails on macos because of updated memory-db and I don't have platform to debug this.
Test failure is not related to this pull request.
memory-db lib
to0.24.1
and add shrink_to_fitoverlay.cumulative_size
instead ofoverlay.backing_overlay.size_of(..)
It is more inaccurate but it is good enough and a it will allow us to skip heavysize_of
.