0x00a329 address is always blacklisted when using a custom config file

openethereum / parity-ethereum

The fast, light, and robust client for Ethereum-like networks.

Other

6.81k stars 1.68k forks source link

0x00a329 address is always blacklisted when using a custom config file #11868

Open bkellerman opened 3 years ago

bkellerman commented 3 years ago

OpenEthereum version: 3.0.0
Operating system: Linux
Installation: dockerhub
Fully synchronized: yes
Network: dev
Restarted: yes

actual behavior

When specifying a custom config file with --chain file.json, the 0x00a329 address is always blacklisted. Only if specific preset chain configs are chosen, will the black list be empty. Logic is here in account_utils.rs

expected behavior

Be able to specify a custom config file and start with an empty blacklist. The reasoning is I want to use a custom config file that adds other accounts, including the 0x00a329 account.

adria0 commented 3 years ago

@tomusdrw maybe do you remember (or do you have any intuition about) why the 00a329c0648769a73afac7f9381e08fb43dbea72 address is explicitly blacklisted here?

https://github.com/openethereum/openethereum/blob/11e40fad8bcb94537326e8ec4e0cddc49ccea651/parity/account_utils.rs#L81-L89

@bkellerman, you specified that you are using the dev chain, this account should be not blacklisted when using this chain.

tomusdrw commented 3 years ago

@adria0 the address is generated from empty Parity Brain Wallet seed. There was quite a lot of issues with people creating this one (possibly due to some UI race condition), so we've decided to disallow it on the node level. See here for instance: https://www.parity.io/restoring-blank-seed-phrase/ or here https://ethereum.stackexchange.com/questions/16347/did-i-generate-an-existing-ethereum-address-in-parity