openethereum / parity-ethereum

The fast, light, and robust client for Ethereum-like networks.
Other
6.82k stars 1.69k forks source link

Not all the tokens are displayed #5765

Closed JanKalin closed 7 years ago

JanKalin commented 7 years ago

A minor annoyance: Not all tokens are displayed. I can see DGD and GNT, but not EMV (Ethereum Movie Venture, https://etherscan.io/address/0xb802b24e0637c2b87d2e8b7784c055bbe921011a). I can add it in the "Contracts" tab of Parity and check the amount by calling balanceOf.

The token does show up in MEW and is supposedly an ERC20 token.

Is there somewhere a list of tokens that Parity scans?

5chdn commented 7 years ago

Parity only displays tokens which are registered with the token registry dapp.

You can check the status in the wallet > applications > token registry and search for the token you are missing. If it's not there, go ahead and register it. All you need is the public token contract address, the numbers of decimals, and an icon.

matt93310 commented 6 years ago

What if it doesn't work and I get the message "The address is not a regular token contract address"?

JanKalin commented 6 years ago

Could you share the address?

What is probably happening is that the contract does not have the standard ERC20 functions, most importantly the balanceOf function that is used in Parity to check balances of accounts and addresses in the addressbook. If it doesn't have the transfer and transferFrom functions, it is also impossible to send tokens.

5chdn commented 6 years ago

What if it doesn't work and I get the message "The address is not a regular token contract address"?

You are either not fully synchronized or the total supply is 0.

JanKalin commented 6 years ago

Again nothing critical, but a token is not displayed properly. It is registered in the registry

image

but it doesn't show up in the wallet info:

image

or the smart contract info

image

5chdn commented 6 years ago

Parity version? Did you try to reset your browser cache yet?

JanKalin commented 6 years ago

Sorry for leaving this out: Parity//v1.8.1-beta-0e4a06d-20171020/x86_64-windows-msvc/rustc1.20.0 And I just cleaned browser cache: no change.

The thing is, it was displaying properly when I added the token to the registry a few days ago.

5chdn commented 6 years ago

I could dig through the changelog now, but please do me the favor and test if this is still an issue with our latest release.

JanKalin commented 6 years ago

Was the same with the latest release. But, strangely, the token registry now showed that the image did not exist. So I re-added metadata. And now everything works as it should.

Although I did change the icon after I had entered a GitHub URL as metadata: https://github.com/JanKalin/misc/commit/5d04b3a52bb77af7d1be9a3049a1ead3b055f37d, https://github.com/JanKalin/misc/commit/09d6dfe8a1b86e0a1dbb2acc5f8387b23d00ce99 and https://github.com/JanKalin/misc/commit/aa5c7fda058a9366482c6cb682f506f8ac9dbd62.

But I looked at the GithubHint contract at 0x27c41d20014fA87291006D02Ddd81B2128039BD7 and that should not matter? In any case, the two hints, 0x8858beaea897b989fc1a4f56206046296a96766d56943aa913c422368c7518ed (original, before icon change) and 0xed94649484312e7ef91cfc681de9c2817ad9f1ff12b7a5a3d757570be527014b (just not) point to exactly the same URL.

I'll let you know if the issue reappears.

ekouris commented 6 years ago

Hey guys, First of all - Happy New Year! I have a quick question: I have just deployed a new token ERA with the total supply of 100,000,000,000 - then I have registered the token using the registry app and it shows up a 1,000.00. Have I messed something up with the number of decimals? Thanks! Evgeni

5chdn commented 6 years ago

If the balances are not correctly displayed - yes :)

matt93310 commented 6 years ago

Hi all, could you please stop copying me in this email chain. My issue has long been resolved by the community and I thank everyone involved towards that outcome. Mathieu

On 3 Jan 2018, at 1:56 pm, Afri Schoedon notifications@github.com wrote:

If the balances are not correctly displayed - yes :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/paritytech/parity/issues/5765#issuecomment-355005752, or mute the thread https://github.com/notifications/unsubscribe-auth/AfkixJiGIyg2mhFlU8Yxt0FHmgbYks1Yks5tG3kRgaJpZM4NwDhn.

5chdn commented 6 years ago

Just unsubscribe on Gihtub. We can not do that for you :)