search

openethereum / pwasm-abi

Parity WASM Abi (Legacy and new)
Apache License 2.0
29 stars 17 forks source link

Alternate multiresult implementation #68

Open cheme opened 6 years ago

cheme commented 6 years ago

Hello, I was updating a branch from months ago and I have seen that I did an alternate implementation for multiresult at the time. I extract it from other changes (partial support for u8 u16 and support for Byte array) to see if it works, seems to pass the test locally . I just PR for information (to communicate this other version), please don't merge this PR (unless the support for tuple of bigger size than 6 is wanted).

NikVolf commented 6 years ago

why closing?

i think it might be better implementation then current ;)

cheme commented 6 years ago

I can reopen (I got the button). I was just thinking of the work to review in comparison to the benefits.