[pleasereview] #17 (conversion to wei) & re-export/use U256/Address instead of type conversion helpers

openethereum / sol-rs

Solaris - Solidity testing framework in Rust.

GNU General Public License v3.0

54 stars 14 forks source link

[pleasereview] #17 (conversion to wei) & re-export/use U256/Address instead of type conversion helpers #18

Closed snd closed 6 years ago

snd commented 6 years ago

[x] add one test for every function with values verified by https://github.com/ethereum/wiki/wiki/JavaScript-API#web3towei
[x] add documentation

snd commented 6 years ago

added tests and documentation. not the biggest fan of all the testing boilerplate and duplication but i don't see a reasonable way to cut down on that. can i get a review?

snd commented 6 years ago

as discussed on riot re-exported U256 and Address and used their conversions instead of custom conversion functions. can i get another review?