search

openethereum / sol-rs

Solaris - Solidity testing framework in Rust.
GNU General Public License v3.0
54 stars 14 forks source link

Add .editorconfig and format with rustfmt. #33

Closed tomusdrw closed 6 years ago

tomusdrw commented 6 years ago

This change is Reviewable

snd commented 6 years ago

looks good except if we merge this, then merging master into https://github.com/paritytech/sol-rs/pull/31 will be a bit of a pain for me. how about i just rustfmt in https://github.com/paritytech/sol-rs/pull/31 ?

tomusdrw commented 6 years ago

@snd sure, we can merge #31 first. I also think that if we use rustfmt in both PRs there shouldn't be many conflicts.

snd commented 6 years ago

could you modify this so it just adds the .editorformat? there's a mix of cargo fmt and various other things on #31 that will likely cause merge problems with the formatting changes here that format code that is now heavily modified. or feel free to close this and i'll then add .editorconfig on a new branch