search

openeuropa / bootstrap-component-library

Openeuropa Bootstrap Component Library
https://oelibrary.netlify.app/
MIT License
15 stars 9 forks source link

feat(headers): Added subthemes header - OEL-1437 #328

Closed tibi2303 closed 2 years ago

github-actions[bot] commented 2 years ago

🚀 Deployed on https://preview-328--oelibrary.netlify.app

planctus commented 2 years ago

It seems all good to me and now the features in ucpkn they show what they are supposed to show, at least regarding hte header, do you know anything about their footer..? Is it really the "neutral" one that we are currently showing..? Do you know anything about it..? :)

For joinup i wonder if we couldn't propose them to put their customisations in BCL, it would be nice to demo the real joinup header and footer, but it's not up to us

There is one story, though, that should also have this applied to, which is "multilingual", there i don't see the ucpkn header.

Ah, since we are not using chromatic on this please sync with development, there is a storybook update, let's avoid messing up the deps.. ;)

Good job!

tibi2303 commented 2 years ago

For the multilingual this are the showcases in figma (Neutral / EC / EU) https://www.figma.com/file/NQlGvTiTXZYN8TwY2Ur5EI/BCL-Features?node-id=5356%3A215100

I am not sure it's needed to show the theme header there.

I asked a question on ux channel for the custom footers, waiting for response. @planctus