openeuropa / bootstrap-component-library

Openeuropa Bootstrap Component Library
https://oelibrary.netlify.app/
MIT License
15 stars 9 forks source link

feat(bootstrap-5.2): Aligning components - OEL-1916 #418

Closed tibi2303 closed 2 years ago

github-actions[bot] commented 2 years ago

🚀 Deployed on https://preview-418--oelibrary.netlify.app

planctus commented 2 years ago

It seems mostly good to me, the UI tests revealed a "leftover" feature: publications listing, about the offcanvas update. The form is not visible. But, about this change, I like the fact that we could remove a custom scss, thanks to this bs update, but i think we should possibly make this a backward compatible change, what i mean is that i would try not to break websites currently using "offcanvas". But how to do this..? Maybe setting by default offcanvas-lg in the template..?