search

openeuropa / drupal-module-template

European Union Public License 1.2
10 stars 6 forks source link

OPENEUROPA-207: Drupal Module template creation. #3

Closed voidtek closed 6 years ago

pfrenssen commented 6 years ago

Closing in favor of #1 which has the original review comments.

pfrenssen commented 6 years ago

Reopening, it wasn't possible to reopen PR #1. This repo was created with an empty master branch, with the intention that PR #1 would become the root, but in the meantime #2 was merged, causing the root to change and now #1 no longer shares a base with master and cannot be reopened.

Please refer to #1 for the related discussion for this PR.

pfrenssen commented 6 years ago

Tests are failing because of docker related errors. I had the same problem in OE Paragraphs, the only way I got the tests to run reliably was by disabling docker.

Here's the commit that fixed it: https://github.com/openeuropa/oe_paragraphs/pull/1/commits/b4496a1f0a2eefe8f1e28cf3d43ae68ca6c46421

pfrenssen commented 6 years ago

The test was restarted on Travis and again it fails, this time because of the commit depth, this is also something that I have already solved in https://github.com/openeuropa/oe_paragraphs/commit/b4496a1f0a2eefe8f1e28cf3d43ae68ca6c46421

voidtek commented 6 years ago

I found a solution for this recurrent issue on travis and docker. I am testing my solution in another branch and I run the build several times (10 times) If the issue does not appear again, I push my solution on this branch.

ademarco commented 6 years ago

We should start using EUPL-1.2 on all our projects, @voidtek could you update it please? Thanks!