search

openeuropa / epoetry-client

PHP client for the ePoetry service.
European Union Public License 1.2
2 stars 2 forks source link

OPENEUROPA-1708: Update soap-client to 1.0 #18

Closed dxvargas closed 5 years ago

dxvargas commented 5 years ago

OPENEUROPA-1708

Description

Update soap-client to 1.0

Change log

dxvargas commented 5 years ago

We have duplicated code in bin/epoetry:

if (is_file($autoload = getcwd() . '/vendor/autoload.php')) {
    require $autoload;
} elseif (is_file($autoload = getcwd() . '/../../autoload.php')) {
    require $autoload;
}

Let's remove that in this ticket as general clean up.

It's not duplicated code, it's for different cases. This is the same approach as soap-client (vendor/bin/soap-client).

dxvargas commented 5 years ago

When running a re-generation I get:

--- a/src/Notification/Type/DgtNotification.php
+++ b/src/Notification/Type/DgtNotification.php
@@ -12,7 +12,7 @@ class DgtNotification
     protected $id;

     /**
-     * @var null|\DateTime
+     * @var null|\DateTimeInterface
      */
     protected $newDeadline;

@@ -65,9 +65,9 @@ class DgtNotification

Why would that be the case?

Fixed!

For the datetime. It has same issues with string vs language as Requests code generation.