openeuropa / oe_bootstrap_theme

Bootstrap-based theme
European Union Public License 1.2
6 stars 13 forks source link

Responsive tables missing the toggle to show/hide "low priority column" #311

Closed msnassar closed 3 months ago

msnassar commented 1 year ago

Drupal responsive table has a toggle to show and hide the columns that have low priority. The toggle (button) exists in the DOM but do not appear on the page because of some missing styles. This is because, core is displaying it when a hidden th is found, see: var hiddenLength = this.$headers.filter('.priority-medium:hidden, .priority-low:hidden').length;

Steps to reproduce:

Suggested fix:

th.priority-low,
th.priority-medium,
td.priority-low,
td.priority-medium {
  display: none;
}

@media screen and (min-width: 38em) {
  th.priority-medium,
  td.priority-medium {
    display: table-cell;
  }
}

@media screen and (min-width: 60em) {
  th.priority-low,
  td.priority-low {
    display: table-cell;
  }
}

image image

tibi2303 commented 8 months ago
image

I see the link is displayed in oe_bootstrap_theme and maybe it was already fixed in some previous versions. From my point of view we can close this issue.

msnassar commented 3 months ago

Closing it as it has been fixed in https://github.com/openeuropa/oe_bootstrap_theme/pull/387