Content banner pattern fixes and improvements - Githubissues

openeuropa / oe_bootstrap_theme

Bootstrap-based theme

European Union Public License 1.2

6 stars 13 forks source link

Content banner pattern fixes and improvements #314

Closed msnassar closed 1 year ago

msnassar commented 1 year ago

Suggested improvement for the content banner pattern:

Make it possible to set the title tag.
Do not display span wrapper when a _meta_item is empty .
Do not display div wrapper when the content is empty.
Add new action_bar field and pass it to the BCL component.

We are currently overriding the pattern because of the issues above. See here https://github.com/digit-devs/echo-ucpkn-dev/blob/master/lib/themes/ucpkn_theme/templates/overrides/patterns/content_banner/pattern-content-banner.html.twig