openeuropa / oe_bootstrap_theme

Bootstrap-based theme
European Union Public License 1.2
6 stars 12 forks source link

AV Portal Video is not sized correctly in featured media pattern #358

Closed kp77 closed 7 months ago

kp77 commented 9 months ago

The AV Portal Video media output contains the default field wrapper. This prevents the .ratio .ratio-16x9 classes to apply the correct sizing styles to the video iframe.

Screenshot 2023-10-26 at 09 58 58

I'm reporting it here, because OE Bootstrap Theme ships those field template overrides that remove the field wrapper from media types (for example: remote video).

Proposed solution: a similar override should be added extending field--bare.html.twig as templates/overrides/field/field--media--av-portal-video.html.twig

OE Bootsrap Theme version: 1.7.0 OE Whitelabel version: 1.3.0

brummbar commented 7 months ago

This does not belong here though, oe_bootstrap_theme doesn't integrate with components. There are some for legacy reason, but they are wrong. They should be in oe_whitelabel.