openeuropa / oe_bootstrap_theme

Bootstrap-based theme
European Union Public License 1.2
6 stars 13 forks source link

OEL-2770: [Gallery pattern] Sentence case for actions #363

Closed julien- closed 4 months ago

julien- commented 9 months ago

At this moment we see "view the full gallery" and "view less". It is better to see "View the full gallery" and "View less"

https://digit-oesa.acc.fpfis.tech.ec.europa.eu/en/patterns/gallery

Patch to apply :

diff --git a/templates/patterns/gallery/pattern-gallery.html.twig b/templates/patterns/gallery/pattern-gallery.html.twig
index 0472187..a02b081 100644
--- a/templates/patterns/gallery/pattern-gallery.html.twig
+++ b/templates/patterns/gallery/pattern-gallery.html.twig
@@ -6,8 +6,8 @@
 #}
 {% extends '@oe-bcl/gallery' %}

-{% set toggle_collapsed = 'view the full gallery (%d)'|t %}
-{% set toggle_expanded = 'view less'|t %}
+{% set toggle_collapsed = 'View the full gallery (%d)'|t %}
+{% set toggle_expanded = 'View less'|t %}
 {% set title_tag = title_tag|default('h2') %}
 {% set items = bcl_gallery_items(items|default([])) %}
 {% set icon_path = bcl_icon_path %}
diff --git a/tests/src/PatternAssertion/GalleryPatternAssert.php b/tests/src/PatternAssertion/GalleryPatternAssert.php
index f296b0e..4b88887 100644
--- a/tests/src/PatternAssertion/GalleryPatternAssert.php
+++ b/tests/src/PatternAssertion/GalleryPatternAssert.php
@@ -43,8 +43,8 @@ protected function assertBaseElements(string $html, string $variant): void {

     $items = $crawler->filter('ul.bcl-gallery__grid li')->count();
     if ($items > 5) {
-      $view_more_text = "view the full gallery ($items)";
-      $this->assertElementText('view less', '.bcl-gallery a.bcl-gallery__collapse span.label-expanded', $crawler);
+      $view_more_text = "View the full gallery ($items)";
+      $this->assertElementText('View less', '.bcl-gallery a.bcl-gallery__collapse span.label-expanded', $crawler);
       $this->assertElementText($view_more_text, '.bcl-gallery a.bcl-gallery__collapse span.label-collapsed', $crawler);
       $this->assertElementText($view_more_text, '.bcl-gallery a.bcl-gallery__mobile-view-more span.label-collapsed', $crawler);