search

openeuropa / oe_theme

Drupal 10 theme based on the Europa Component Library (ECL).
European Union Public License 1.2
31 stars 31 forks source link

missing core/once to libraries.yml #1313

Open john4190 opened 1 year ago

john4190 commented 1 year ago

in order to fully support js asset injection i strongly suggest to include core/once in theme dependencies

brummbar commented 1 year ago

Js assets should be libraries, and they can declare their dependencies.

brummbar commented 1 year ago

... unless you mean in the current libraries we have. On that I agree :)

john4190 commented 1 year ago

yes but i am not trying to create a new module, i am trying to exploit ECL components in order to make search page as compliant as possible to European union guidelines. Moreover fortunately there are modules for injecting small pieces of javascript without creating a new module and without disrupting everything

Il giorno mer 6 set 2023 alle ore 15:53 Francesco @.***> ha scritto:

Js assets should be libraries, and they can declare their dependencies.

— Reply to this email directly, view it on GitHub https://github.com/openeuropa/oe_theme/issues/1313#issuecomment-1708420739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYD4JV4O4TLYUBGYUWQG3LXZB547ANCNFSM6AAAAAA4EEVPJ4 . You are receiving this because you authored the thread.Message ID: @.***>

john4190 commented 1 year ago

anyway yes having core/once helps you as well if you have to handle events in the drupal way and keep everything compatible with drupal 10