openeuropa / oe_whitelabel

European Union Public License 1.2
2 stars 4 forks source link

Pass block's attributes to offcanvas pattern for block--facets-form.html.twig #210

Closed msnassar closed 9 months ago

msnassar commented 1 year ago

We would like to hide the facets form when all facets are hidden. In order to do that -as a workaround- we preprocess the facets form block and set 'd-none' class when the condition is met. But the class is not added to the block. This is because the block's template doesn't pass the attributes to the offcanvas pattern!

It would be nice to have settings for the facets form to hide the form when all facets are hidden https://www.drupal.org/project/facets_form/issues/3344978. Similar issues: Facets: https://www.drupal.org/project/facets/issues/2984465 Facets block: https://www.drupal.org/project/facets_block/issues/3207373

brummbar commented 9 months ago

Will be fixed in #237 .