search

openeuropa / oe_whitelabel

European Union Public License 1.2
2 stars 4 forks source link

UCPKN-3056: Agenda theming. #268

Open kp77 opened 3 months ago

kp77 commented 3 months ago

Hi @brummbar,

The PR is still wip, without tests. There are some changes since we last discussed, most importanty that I ended up adding templates/preprocesses only for the bundles that are shipped by oe_agenda, and I don't override the general entity templates. I think it's cleaner like this, because we use bundle fields in all the templates.

This affected the session templates a bit, so now I don't have a oe-agenda-session.html.twig that the oe-default and oe-break templates are extending, instead the oe-break template extends the oe-default (but otherwise the idea is the same). Let me know what you think, I will add comments to the code where I have something to say.

kp77 commented 2 months ago

Hi @msnassar,

I added 3 new commits since last review round:

  1. UCPKN-3056: Normalize spacing between session sections. is the proposed solution for the inconsistency between sessions and session sections (this is what UCPKN-3105 ticket was created for as a follow up)
  2. UCPKN-3056: Set correct size/spacing for break/default session title. fixed session title font size and spacing to align with mockup
  3. UCPKN-3056: Display hours as muted only for break session. the text-muted class was incorrectly applied on the default session hours, but they should be muted only in break session