search

openeventdata / UniversalPetrarch

Language-agnostic political event coding using universal dependencies
MIT License
18 stars 9 forks source link

Why is Python3 code in a separate directory? #39

Closed ahalterman closed 6 years ago

ahalterman commented 6 years ago

Why is the Python 3 code in a separate directory in UniversalPetrarch instead of just converting the existing code to be 2/3 compatible? There's a big risk of the two code bases diverging unless every change to one gets manually copied over to the other.

JingL1014 commented 6 years ago

Some functions of the NetworkX package in python2 and python3 have different return types, so it is a little bit hard to have 2/3 compatible code. Do we really want to have 2/3 compatible version? Or is it okay to just keep python3 version?

ahalterman commented 6 years ago

I think it's okay to just have 3, though other people might think differently. The other option is to just re-write the Python 2/3 specific parts around networkx and execute different blocks based on which version is running.

JingL1014 commented 6 years ago

The coder now is python 2/3 compatible, and I removed the directory python3/.