search

openeventdata / UniversalPetrarch

Language-agnostic political event coding using universal dependencies
MIT License
18 stars 9 forks source link

Function `skip_item()` in PETRgraph.py is, at best, specific to English #50

Open philip-schrodt opened 5 years ago

philip-schrodt commented 5 years ago

but more generally looks like a debugging function (I think it was Clayton's, not mine), as "DUCATS" were a valued item produced by those lovable bankers in the Venetian Republic during medieval times, but haven't been in circulation for a century or more. And the rest of the function is definitely specific to English (but probably shouldn't be called in that context either)

PTB-OEDA commented 5 years ago

Have we cut this?

On Tue, Oct 23, 2018, 14:25 Philip Schrodt notifications@github.com wrote:

but more generally looks like a debugging function (I think it was Clayton's, not mine), as "DUCATS" were a valued item produced by those lovable bankers in the Venetian Republic during medieval times, but haven't been in circulation for a century or more. And the rest of the function is definitely specific to English (but probably shouldn't be called in that context either)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openeventdata/UniversalPetrarch/issues/50, or mute the thread https://github.com/notifications/unsubscribe-auth/AJrP1hN86qEc_xpN-KrpSNbLgRk4m9iGks5un20hgaJpZM4X2eul .