Integrate Mordecai geocoding service into pipeline

openeventdata / phoenix_pipeline

Turning news into events since 2014.

MIT License

50 stars 33 forks source link

Integrate Mordecai geocoding service into pipeline #96

Closed ahalterman closed 8 years ago

ahalterman commented 8 years ago

The pipeline can now run with Mordecai for geocoding rather than CLIFF. The geolocation service can be selected in the config file.

Before merging, I need to:

Check that nothing broke for CLIFF (need to run on a server that has CLIFF)
Write unit tests once I'm sure nothing needs to change.
Update the README.

ahalterman commented 8 years ago

I'm getting close on these remaining issues. Anything else I need to take care of while I'm at it, @johnb30?

johnb30 commented 8 years ago

From a quick glance everything looks solid to me.

ahalterman commented 8 years ago

Docs and tests are already being done in another branch and I'm afraid of another horrible merge conflict, so I'm going to merge this in and do tests and docs afterward.