Closed wbotelhos closed 9 years ago
Sorry! Check it out.
@wbotelhos looks good. Unfortunately it seems that @openexchangerates doesn't update this project anymore. See #107. Perhaps @josscrowcroft should get involved again.
Thanks for the PR @wbotelhos and corrections/heads up @dotnetCarpenter. Looks good!
@josscrowcroft Nice! We need you to create a tag for the release before it takes effect with bower.
git checkout master
git tag v0.4.1 -am "version 0.4.1"
git push origin master --tags
Can you write here when you do? Then I can point to this repo instead of https://github.com/dotnetCarpenter/accounting.js Thanks
Have added the tag. Cheers!
@josscrowcroft thanks for the release. unfortunately you didn't release the commit with the bower.json
file, so my build system is still not working.
Release 0.4.1 without bower.json: https://github.com/openexchangerates/accounting.js/tree/9b73d760f20fb5bd87a570f7b7ecf9af9cf5b76c
You need to tag the current master and probably bump the minor version.
My mistake. Tagged new minor version with bower.json.
@josscrowcroft Sorry for bothering you again but you need to tag the commit with bower.json.
bower update
bower accountingjs#^0.4.2 not-cached git://github.com/openexchangerates/accounting.js.git#^0.4.2
bower accountingjs#^0.4.2 resolve git://github.com/openexchangerates/accounting.js.git#^0.4.2
bower typed.js#~1.1.1 cached git@github.com:dotnetCarpenter/typed.js.git#1.1.1
bower typed.js#~1.1.1 validate 1.1.1 against git@github.com:dotnetCarpenter/typed.js.git#~1.1.1
bower jquery#^2.1.4 cached git://github.com/jquery/jquery.git#2.1.4
bower jquery#^2.1.4 validate 2.1.4 against git://github.com/jquery/jquery.git#^2.1.4
bower accountingjs#^0.4.2 ENORESTARGET No tag found that was able to satisfy ^0.4.2
Additional error details:
Available versions: 0.4.1, 0.3.2, 0.3.0, 0.2.2, 0.2.1, 0.1.5, 0.1.4, 0.1.3, 0.1.2, 0.1.1
The way bower works is by looking at your github tags. You don't need and probably shouldn't have any version in your bower.json but only use git tag v0.4.2 -am "release info"
. A git tag always point to a commit in a branch. By default the current commit in the branch you have checked out. Bower also only recognize semver version numbers. That is: every version has a MAJOR.MINOR.PATCH number format. Hope this explains..
Actually I can update accounting.js via bower sorely on your git tag. In fact I start to wonder why you'll ever want a bower.json when you have a package.json.... Haven't thought about this before.
Cool. So this is resolved for you?
And I wonder about the repo, whether we need the bower.json file - not doing any harm, as long as it works. I'll leave the discussion to somebody with more bower experience though.
@josscrowcroft Stil isn't resolved. I'm still seeing 0.4.1 as the latest version on npm.
(Thanks for your time on this project. Accounting.js makes my javascript life so much better!)
Your PR is invalid. You need to have valid json in the bower.json.