search

openexchangerates / accounting.js

A lightweight JavaScript library for number, money and currency formatting - fully localisable, zero dependencies.
http://openexchangerates.github.io/accounting.js
MIT License
4.95k stars 528 forks source link

update docs so toFixed is marked as faulty and not working #111

Closed vizcay closed 7 years ago

vizcay commented 8 years ago

I've choosen accounting.js as my formating / rounding js lib. According to homepage, toFixed solves js rounding inconsistencies as we expect base 10 classical rounding for monetary values.

Now after some time in production bugs started to appear because it fails to deliver what it promises:

accounting.toFixed(158.605, 2) = 158.60 accounting.toFixed(259.605, 2) = 259.61

Of course bugs happen in the best projects, but misleading potential users with bad info in the home page when now I see that there are bugs reports about this months ago is no fun.

elekktrisch commented 8 years ago

This is a duplicate of https://github.com/openexchangerates/accounting.js/issues/99 and https://github.com/openexchangerates/accounting.js/issues/94

wjcrowcroft commented 7 years ago

Thanks, this is fixed by #164.