openexchangerates / accounting.js

A lightweight JavaScript library for number, money and currency formatting - fully localisable, zero dependencies.
http://openexchangerates.github.io/accounting.js
MIT License
4.95k stars 528 forks source link

Unable to Install version 0.4.2 via bower #119

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi!

I was unable to install the latest version(0.4.2) via bower install. The latest version available thru bower is 0.3.2. Please see the attached image.

screen shot 2015-11-04 at 12 02 15 pm copy

Thank you!

tswestendorp commented 8 years ago

+1

dotnetCarpenter commented 8 years ago

It should be known to @josscrowcroft how to create a bower/github release, that a git tag is what creates a github release and that bower is fueled by these releases and not the bower.json file and that versions MUST be semver (e.i. v0.4.2) versions or bower won't recognize them.

This has been broad to attention numerous times:

  1. 117

  2. 110

  3. 107

  4. 106

  5. 86

  6. 50

If you read this and feel a bit in despair, fret not and just point bower to dotnetCarpenter/accounting.js, I promise to keep that repo up to date with this one and create proper bower releases.

Either do bower install --save dotnetCarpenter/accounting.js or add this line to the dependencies section in your bower.json file:

"dependencies": {
    "accounting": "dotnetCarpenter/accounting.js#~0.4.2"
}

If you are @josscrowcroft and you are not sure how you can fix this returning issue, just open your terminal/console and type the following in the accounting.js directory:

git tag v0.4.2
git push --tag origin master
pderksen commented 8 years ago

Please fix! :)

chadsaun commented 8 years ago

+1

dotnetCarpenter commented 8 years ago

@chadsaun you can use my fork https://github.com/dotnetcarpenter/accounting.js/ I will keep it updated with changes from upstream (this repo).