Unformat invalid - Githubissues

openexchangerates / accounting.js

A lightweight JavaScript library for number, money and currency formatting - fully localisable, zero dependencies.

http://openexchangerates.github.io/accounting.js

MIT License

4.95k stars 528 forks source link

Unformat invalid #122

Open spidergears opened 8 years ago

spidergears commented 8 years ago

Ref: #98

fixed with

on failure return user specified response
on failure response defaults to 0 as in previous versions

bmode commented 8 years ago

This looks like a good solution to me. My only comment would be to rename the new parameter. The current name, "on_failure", sounds to me like a callback function, which it is not. How about "failure_value" or "failure_result" or something similar?

spidergears commented 8 years ago

Done!!