search

openexchangerates / accounting.js

A lightweight JavaScript library for number, money and currency formatting - fully localisable, zero dependencies.
http://openexchangerates.github.io/accounting.js
MIT License
4.95k stars 532 forks source link

IE Testing & Bug Fixing #18

Closed wjcrowcroft closed 12 years ago

wjcrowcroft commented 13 years ago

Need to do some rigorous IE testing for the current code and the 0.1.4 version currently on the dev branch.

If anyone finds and bugs in IE, please use this thread for them.

HenriPablo commented 12 years ago

Howdy! Just noticed that in IE 7 & 8 symbol needs to be passed in, otherwise it errors out looking for the symbol:

call to func: accounting.formatMoney( uniqueMember.campaignGoal )

error: SCRIPT5007: Unable to get value of the property 'symbol': object is null or undefined

wjcrowcroft commented 12 years ago

Good catch, thanks. I won't be able to fix this for 2 weeks or so as I'm away for a while, but it sounds like a pretty important bug so will try to have a look if I can find a windows laptop, or see if I can spot the error.

Reckon you can see what's causing this one?

mcordingley commented 12 years ago

This issue is covered in my bug-fix on pull request 29. I ran into the exact same thing when testing our app in IE.

wjcrowcroft commented 12 years ago

Thanks! I'll get the bug fix merged in to the main branch tomorrow.