0.3.0 - Githubissues

ducdigital commented 8 years ago

This version is maintained here: https://github.com/ducdigital/money.js Feel free to give comment, add more tests and new feature in a PR.

In this version all API of money.js remain the same but introduce new features to this project.

Change Log

0.3.0

Factory for money.js. Allow create multiple instance of money.js in the same app. Thanks @starsirius: (https://github.com/starsirius/money.js/commit/a736a83912d7f62f360f8d623c785f148e8f50d4). For: #25
Proper error message instead of showing fx error. Thanks @sliptree: (https://github.com/sliptree/money.js/commit/c76476456f1acef18c0b2441d36de3f55ae3650b). For: #24
Unit test. Inpired by (@PierrickP) (https://github.com/PierrickP/money.js/commit/b2b5e32b2b0cbf13a334e4590b3ac2356c545b89). For: #14
Expose fx.getRate(to, from) allow getting rate from any 2 currencies. Inspired by (@thewarpaint): (https://github.com/thewarpaint/money.js/commit/85eed2df55c3022ac6fe7fe83911ecf2a2b8a25d). For: #4
Fix small bug cause value not passed to getRate()

PierrickP commented 8 years ago

:+1:

asfktz commented 6 years ago

Hi @ducdigital! This PR looks so promising. Multiple instance support is definitely needed.

What stops it from being merged? Is there anything I can do to help?

jsw commented 6 years ago

Bump. Is this project abandoned?

ducdigital commented 6 years ago

Hi there @asfktz and @jsw

I am just contributing to this opensource project and have no right to merge this branch to master.

If you use it, just use git format in your package.json like ff:

    "money": "github:ducdigital/money.js",

It seems like the PR is not gonna get merge anytime soon.

asfktz commented 6 years ago

Hi, @ducdigital! How about releasing it as an NPM package of its own? Something like money2 sounds good to me 😊