openfaas-incubator / faas-rancher

Serverless with Rancher 1.x and (OpenFaaS)
https://github.com/openfaas/faas
MIT License
23 stars 7 forks source link

Update to faas 0.8.1 #7

Open roomthirteen opened 5 years ago

roomthirteen commented 5 years ago

Hi @alexellis,

this is my pull request to make faas-rancher compatible with the new faas ui, introducing not only the availableReplicas property in the function list but also all other new provider endpoints. There are two shortfalls:

  1. Missing tests because i do not understand the go testing framework due my limitation in the understanding of the go programming language.

  2. Async rancher service upgrade. Redeploying a function will be done in an async manner due to rancher taking quite some time to upgrade a service. When the redeployment leads to an error, it will leave the rancher service in an inconsistent state instead of doing a rollback which in my opinion is not an issue, since you want to investigate why the redeployment of the function did not work.

What do you think?