search

openfaas-incubator / node8-express-template

Node.js 8 template for OpenFaaS with HTTP via Express.js
MIT License
15 stars 18 forks source link

Update Base Image to Node 10 #13

Open Templum opened 6 years ago

Templum commented 6 years ago

Node 10 will be released on the 2018-10-30 and will become the new LTS. If that happens we should update the base image to Node 10.

Also it might be advisable to rename the repository. As it containts node8

alexellis commented 6 years ago

Renaming the repository will break for so many people, that's not really an option.

A new repository with an alternative name seems like the sane thing to do right now - that or make "LTS" a moving target - node-lts-express (but this may also cause breakage for people moving between LTS versions).

Alex

alexellis commented 6 years ago

https://github.com/openfaas-incubator/node10-express-template

rimiti commented 6 years ago

@alexellis Why did you not created node-express-template instead of node10-express-template ? I don't understand why it's necessary to add node version into the name of the repository.

alexellis commented 6 years ago

It's important to make sure that we do not break a user's functions and production workflow. If there is a breaking change between two Node versions then that needs to be mitigated. By using a version in the repository we can allow both to be used at once and leave it up to the developer/company to move when they want. Does this make sense?