search

openfaas-incubator / node8-express-template

Node.js 8 template for OpenFaaS with HTTP via Express.js
MIT License
15 stars 18 forks source link

Added support for multipart uploads #2

Closed satie closed 6 years ago

satie commented 6 years ago

Added support for multipart uploads using multer.

alexellis commented 6 years ago

Hi @satie, why is a multi-part upload needed for a function? Ideally we should be running read-only. Could this be passed in via the body instead?

If the file is too large then store it in S3/Minio before pulling into /tmp/ for use in the function.

Alex

rimiti commented 6 years ago

I'm totally agree with @alexellis, you should not use multipart.

alexellis commented 6 years ago

Derek close: inactive PR

satie commented 6 years ago

@alexellis - my apologies for not following up. I agree with the recommendation to not use multipart. For my use case, I am now uploading files to minio and passing the object information to the function.

Thank you for your support!

alexellis commented 6 years ago

No problems. What are you using it for now?