Add Dockerfile for govc

openfaas-incubator / vcenter-connector

Extend vCenter with OpenFaaS

MIT License

28 stars 8 forks source link

Closed embano1 closed 5 years ago

embano1 commented 5 years ago

Follows the syntax from #1 (even though apk add git seems redundant in a golang image (suggest making use of go get)
Default behaviour when the image is executed runs govc which outputs supported commands (can be overwritten)
In the README instructions for the connector we should mention how to correctly invoke govc, incl. commonly used environment variables (https://github.com/vmware/govmomi/tree/master/govc#usage).

Signed-off-by: Michael Gasch embano1@live.com

alexellis commented 5 years ago

Adding git was required in the Go image for Alpine.

alexellis commented 5 years ago

Thanks for the PR.

embano1 commented 5 years ago

Thx @alexellis

Did not want to mess up the structure as I am not too familiar with OpenFaaS contrib best practices (regarding folder structure, etc.).

Happy to file another one moving the folders to:

<root>
    |- contrib
             |-govc
             |-vcsim

alexellis commented 5 years ago

Please :+1: and any readme alterations that may be needed.