Add ManagedObjectReference and more events supported

[embano1]

• Changes:

  • Many important vCenter events supported now
  • Split event handling in separate pkg
  • JSON key in outbound Message is now ManagedObjectReference for functions to check
  • Robust vCenter client connection/error handling
  • Clean shutdown via os.Signal
  • Fixed a bug where -insecure was never populated
  • Improved error handling and logging (removed panics)
  • More comments in the code
  • Dockerfiles updated
  • dep ensure was out of sync
  • README fixes and updates reflecting new events supported
  • New docs section for examples
  • Bumped Docker image version for the connector to 0.4 (until official OpenFaaS builds are used)
  • Updated external examples (gotagfn, pytagfn) to use new JSON key

• Tested with:

  • vCenter 6.5
  • Kubernetes: kindest/node:v1.13.3 (kind version 0.2.0-alpha)
  • OpenFaaS: faas-netes (Commit 07bca00)
  • Python demo function pytagfn (Commit 99e2eea)

• Improvements for further PRs:

  • Migrate to latest openfaas-sdk version
  • Add code examples to repo instead personal repo
  • Switch to official builds in YAML
  • When govmomi ships govc/vcsim Docker images, use them

Signed-off-by: Michael Gasch embano1@live.com

[ivanayov]

Hi @embano1 Can you please add a "How has this been tested" section? Looks good

[embano1]

Thx @ivanayov

Actually, I found some more issues, e.g. the "insecure" flag actually was never used. I've done several changes and need to do more testing.

How would you like me to update this PR in terms of commit? Squash them all into one commit and force push?

[ivanayov]

@embano1 if they are fixes and refactoring of the same change, then should better go in a single commit

[alexellis]

Is this still WIP?

[embano1]

PR updated with changes outlined in the commit message.

[embano1]

@alexellis thx for your thorough review! What I changed based on your feedback:

• fixed the Dockerfiles
• example is now in docs
• moved event logic into a separate package (events.go)
• added a function getmoref to break out the switch statements for the events, returning *vtypes.ManagedObjectReference
• added a test for getmoref() in events.go to check for valid/supported events

[alexellis]

Next step - let's see the password read from a Kubernetes secret file?

Alex