Update Connector Dockerfile

openfaas-incubator / vcenter-connector

Extend vCenter with OpenFaaS

MIT License

28 stars 8 forks source link

Update Connector Dockerfile #13

Closed embano1 closed 5 years ago

embano1 commented 5 years ago

There is no need to copy the full build context into the final stage image
Changed to only copy the connector binary to the final image

Signed-off-by: Michael Gasch embano1@live.com

ivanayov commented 5 years ago

Thanks @embano1 Looks good

embano1 commented 5 years ago

Thx, before we merge: is it ok to also add common ca-certificates? I would add apk add --no-cache ca-certificates to the final image, if ok?

Btw: do you prefer another commit or combine into a single and force push?

ivanayov commented 5 years ago

@embano1 good point for the certificates. I think we should add them to vcsim as well. WDYT?

alexellis commented 5 years ago

LGTM

alexellis commented 5 years ago

Thank you for the PR.

I didn't add the certs because I assume that we are not connecting to any sites with a TLS cert from a public CA bundle? Happy to take a PR if you'd like to add it.