search

openfaas-incubator / vcenter-connector

Extend vCenter with OpenFaaS
MIT License
28 stars 8 forks source link

Add vCenter Source to Event #23

Closed mikejwhitehead closed 4 years ago

mikejwhitehead commented 5 years ago

resolves #22

This PR adds the vcenter source to the OutboundEvent, allowing the subscribed function(s) to handle events across multiple vcenters.

derek[bot] commented 5 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 5 years ago

Please can you squash or reset both of these commits into one?

You can also get your email set consistently like this:

git config user.name "Mike Whitehead"
git config user.email "mwhitehead@nvidia.com"

Alex

alexellis commented 5 years ago

@embano1 are you OK with the naming etc in the event?

embano1 commented 5 years ago

LGTM Thank you!

alexellis commented 4 years ago

Sorry this couldn't be merged due to the lack of DCO. See: 0d02cc89aa74beaeaeaf9e049aa868abc8ac729b for this change.